deps: Disable dependency default-features by default; upgrade dependencies to latest#454
Open
bryantbiggs wants to merge 5 commits intocontainerd:mainfrom
Open
deps: Disable dependency default-features by default; upgrade dependencies to latest#454bryantbiggs wants to merge 5 commits intocontainerd:mainfrom
default-features by default; upgrade dependencies to latest#454bryantbiggs wants to merge 5 commits intocontainerd:mainfrom
Conversation
default-features by default; upgrade dependencies to latest
…lippy errors from increase
ba2f21c to
5692c86
Compare
Contributor
Author
|
cc @mxpv if you have some time |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
default-features = false, forcing explicit feature opt-in to ensure only the necessary dependencies are pulled in. Dependencies were updated to the latest during this changecontainerd_clientpulls in server side oftonic#451Summary:
However, this isn't the complete picture. Per crate, it will vary based on what is removed due to scoping the features used by each crate.
Fixes pre-existing correctness and hygiene issues discovered during the dependency cleanup work.
Let me know if this commit needs to move to a separate PR:
sysconf(_SC_PAGESIZE). The rawsysconfresult was cast directly tousize, silently producingusize::MAXon error and causing incorrect page size checks for overlay mount compaction.PipedIo::close_after_start.close_after_start()closed a rawfdwhile the owning type still held it, leading to a double-close on drop. If thefdnumber was reused between the two closes, this could silently close an unrelatedfdbelonging to another part of the process.prefix_filter. Dead if-let binding replaced with a simplerstarts_with()check.Pipeto usestd::io::pipe(). The async pipe unnecessarily went throughtokio::net::unix::pipeand then converted back to blockingfds. Now usesstd::io::pipe()directly, consistent with the sync pipe.#![allow(unused)]frommount_linux.rs. The file-level suppression hid real warnings. Replaced with targetedcfggates on feature-specific imports and a scoped allow onMountInfowhose fields are populated during parsing for completeness.